linux-kernel - Re: [PATCH] net: dsa: mv88e6xxx: fix unused function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2TbA_KjR-sUNufhr=D0GD9PH91o0VB41VL+UB7tpfk6A@mail.gmail.com>
Date:   Mon, 4 Mar 2019 22:08:31 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Marek Behún <marek.behun@....cz>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix unused function warning

On Mon, Mar 4, 2019 at 9:42 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 04.03.2019 21:36, Arnd Bergmann wrote:
> > The newly introduced function is only used inside of an #ifdef
> > and causes a warning when that is disabled:
> >
> > drivers/net/dsa/mv88e6xxx/chip.c:4623:13: error: unused function 'mv88e6xxx_ports_cmode_init' [-Werror,-Wunused-function]
> >
> > Move it into the same #ifdef block to shut up the warning.
> >
> > Fixes: ed8fe20205ac ("net: dsa: mv88e6xxx: prevent interrupt storm caused by mv88e6390x_port_set_cmode")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> A fix has been submitted already. See discussion here:
> https://marc.info/?t=155170356600004&r=1&w=2
> and the fix here:
> https://patchwork.ozlabs.org/patch/1051275/

Ok, that looks good, thanks for the reply!

     Arnd