linux-kernel - Re: [PATCH v2] f2fs: fix to check inline_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82ef0ff8-452c-1894-6776-41c70ad7654b@huawei.com>
Date:   Mon, 4 Mar 2019 14:39:06 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Chao Yu <chao@...nel.org>, <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] f2fs: fix to check inline_xattr_size boundary
 correctly

Hi Jaegeuk,

On 2019/2/15 0:08, Chao Yu wrote:
> ---
> v2:
> - fix lower bound check, inline xattr size should be larger than
> xattr_header's size at least.

...

> +		if (F2FS_OPTION(sbi).inline_xattr_size <
> +			sizeof(struct f2fs_xattr_header) / sizeof(__le32)

No sure we should set this low bound as above... now I guess original
non-zero check is enough.

How do you think of setting inline_xattr_size range as
(0, MAX_INLINE_XATTR_SIZE]?

Thanks,