linux-kernel - Re: [PATCH 1/7] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Mar 2019 08:37:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yifeng Li <tomli@...li.me>
Cc:     kbuild-all@...org, Lee Jones <lee.jones@...aro.org>,
        linux-mips@...r.kernel.org, Yifeng Li <tomli@...li.me>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhc@...ote.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote
 Yeeloong laptops.

Hi Yifeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc8]
[cannot apply to next-20190301]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yifeng-Li/Preliminary-Platform-Driver-Support-for-Lemote-Yeeloong-Laptops/20190304-005203
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers//mfd/yeeloong_kb3310b.c: In function 'kb3310b_read':
>> drivers//mfd/yeeloong_kb3310b.c:70:2: error: implicit declaration of function 'outb'; did you mean 'mftb'? [-Werror=implicit-function-declaration]
     outb((reg & 0xff00) >> 8, KB3310B_IO_PORT_HIGH);
     ^~~~
     mftb
   drivers//mfd/yeeloong_kb3310b.c:72:8: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
     val = inb(KB3310B_IO_PORT_DATA);
           ^~~
   cc1: some warnings being treated as errors

vim +70 drivers//mfd/yeeloong_kb3310b.c

    62	
    63	u8 kb3310b_read(u16 reg)
    64	{
    65		unsigned long flags;
    66		u8 val;
    67	
    68		spin_lock_irqsave(&kb3310b_index_lock, flags);
    69	
  > 70		outb((reg & 0xff00) >> 8, KB3310B_IO_PORT_HIGH);
    71		outb((reg & 0x00ff), KB3310B_IO_PORT_LOW);
    72		val = inb(KB3310B_IO_PORT_DATA);
    73	
    74		spin_unlock_irqrestore(&kb3310b_index_lock, flags);
    75	
    76		return val;
    77	}
    78	EXPORT_SYMBOL_GPL(kb3310b_read);
    79	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59648 bytes)