linux-kernel - Re: [PATCH 4.20 12/88] usb: dwc3: gadget: synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3d017c7-d671-3ba9-15d6-0028595d5d59@samsung.com>
Date:   Mon, 4 Mar 2019 10:03:27 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "He, Bo" <bo.he@...el.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Wang, Yu Y" <yu.y.wang@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.20 12/88] usb: dwc3: gadget: synchronize_irq dwc irq
 in suspend

Hi Greg,

On 2019-03-04 09:53, Greg Kroah-Hartman wrote:
> On Mon, Mar 04, 2019 at 08:46:30AM +0000, He, Bo wrote:
>> Hi, Greg:
>> 	Marek Szyprowski report the patch has issue that calling synchronize_irq() under dwc->lock spinlock, he has upload the below patch for the issue:
>>
>> dwc3_gadget_suspend() is called under dwc->lock spinlock. In such context calling synchronize_irq() is not allowed. Move the problematic call out of the protected block to fix the following kernel BUG during system
> <snip>
>
> Is this patch in Linus's tree yet?  If so, what is the git commit id?
>
> If not, is this also an issue in 5.0?

The fix has not been merged yet. The issue is also present in v5.0.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland