linux-kernel - Re: [PATCH] ACPI/PPTT: Simplify leaf node detection.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Mar 2019 10:02:08 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     linux-acpi@...r.kernel.org, rjw@...ysocki.net, lenb@...nel.org,
        Lorenzo.Pieralisi@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] ACPI/PPTT: Simplify leaf node detection.

On Fri, Mar 01, 2019 at 12:52:21PM -0600, Jeremy Linton wrote:
> ACPI 6.3 bumps the PPTT table revision and adds a LEAF_NODE flag.
> This allows us to avoid a second pass through the table to assure
> that the node in question is a leaf.
>

Reviewed-by:Sudeep Holla <sudeep.holla@....com>

--
Regards,
Sudeep

> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
> ---
>  drivers/acpi/pptt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
> index ad31c50de3be..065c4fc245d1 100644
> --- a/drivers/acpi/pptt.c
> +++ b/drivers/acpi/pptt.c
> @@ -209,6 +209,9 @@ static int acpi_pptt_leaf_node(struct acpi_table_header *table_hdr,
>  	struct acpi_pptt_processor *cpu_node;
>  	u32 proc_sz;
>
> +	if (table_hdr->revision > 1)
> +		return (node->flags & ACPI_PPTT_ACPI_LEAF_NODE);
> +
>  	table_end = (unsigned long)table_hdr + table_hdr->length;
>  	node_entry = ACPI_PTR_DIFF(node, table_hdr);
>  	entry = ACPI_ADD_PTR(struct acpi_subtable_header, table_hdr,
> --
> 2.20.1
>