lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 4 Mar 2019 12:01:37 +0000
From:   Steven Price <>
To:     "Kirill A. Shutemov" <>
Cc:     Mark Rutland <>,
        Peter Zijlstra <>,
        Catalin Marinas <>,
        Dave Hansen <>,
        Will Deacon <>,,
        "H. Peter Anvin" <>,
        "Liang, Kan" <>,,,
        Ingo Molnar <>,
        Mark Salter <>,
        Arnd Bergmann <>,
        Aurelien Jacquiot <>,
        Jérôme Glisse <>,
        Borislav Petkov <>,
        Andy Lutomirski <>,
        Thomas Gleixner <>,,
        Ard Biesheuvel <>,, James Morse <>
Subject: Re: [PATCH v3 05/34] c6x: mm: Add p?d_large() definitions

On 01/03/2019 21:48, Kirill A. Shutemov wrote:
> On Wed, Feb 27, 2019 at 05:05:39PM +0000, Steven Price wrote:
>> walk_page_range() is going to be allowed to walk page tables other than
>> those of user space. For this it needs to know when it has reached a
>> 'leaf' entry in the page tables. This information is provided by the
>> p?d_large() functions/macros.
>> For c6x there's no MMU so there's never a large page, so just add stubs.
> Other option would be to provide the stubs via generic headers form !MMU.

I agree that could be done, but equally the definitions of
p?d_present/p?d_none/p?d_bad etc could be provided by a generic header
for !MMU but currently are not. It makes sense to keep the p?d_large
definitions next to the others.

I'd prefer to stick with a (relatively) small change here - it's already
quite a long series! But this is certainly something that could be
tidied up for !MMU archs.


Powered by blists - more mailing lists