linux-kernel - Re: [PATCH v3] x86/boot: Fix incorrect ifdeffery scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Mar 2019 21:28:04 +0800
From:   Baoquan He <bhe@...hat.com>
To:     linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
        x86@...nel.org
Cc:     fanc.fnst@...fujitsu.com, bp@...en8.de
Subject: Re: [PATCH v3] x86/boot: Fix incorrect ifdeffery scope

On 03/04/19 at 06:17pm, Baoquan He wrote:
> Add Thomas and Ingo to CC, and x86 ML.

Sorry, forgot saying this is on tip/x86/boot branch.

> 
> On 03/04/19 at 01:55pm, Baoquan He wrote:
> > The declarations related to immovable memory handling are put out of
> > the BOOT_COMPRESSED_MISC_H #ifdef scope, wrap them inside.
> > 
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > ---
> > v2->v3:
> >   Add code comment to clearly note the end of the ifdeffery for better
> >   code reading.
> > v1->v2:
> >   Add the lost line which could be made by git.
> >  arch/x86/boot/compressed/misc.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
> > index fd13655e0f9b..d2f184165934 100644
> > --- a/arch/x86/boot/compressed/misc.h
> > +++ b/arch/x86/boot/compressed/misc.h
> > @@ -120,8 +120,6 @@ static inline void console_init(void)
> >  
> >  void set_sev_encryption_mask(void);
> >  
> > -#endif
> > -
> >  /* acpi.c */
> >  #ifdef CONFIG_ACPI
> >  acpi_physical_address get_rsdp_addr(void);
> > @@ -135,3 +133,5 @@ int count_immovable_mem_regions(void);
> >  #else
> >  static inline int count_immovable_mem_regions(void) { return 0; }
> >  #endif
> > +
> > +#endif /* BOOT_COMPRESSED_MISC_H */
> > -- 
> > 2.17.2
> >