[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190304144606.GA7466@e107155-lin>
Date: Mon, 4 Mar 2019 14:46:06 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Wen Yang <wen.yang99@....com.cn>
Cc: liviu.dudau@....com, lorenzo.pieralisi@....com,
linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, kgene@...nel.org, krzk@...nel.org,
linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com,
afaerber@...e.de, manivannan.sadhasivam@...aro.org,
dinguyen@...nel.org, heiko@...ech.de,
linux-rockchip@...ts.infradead.org, f.fainelli@...il.com,
rjui@...adcom.com, sbranden@...adcom.com,
bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org,
avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com,
yuenn@...gle.com, brendanhiggins@...gle.com,
openbmc@...ts.ozlabs.org, xuwei5@...ilicon.com,
maxime.ripard@...tlin.com, wens@...e.org, catalin.marinas@....com,
will.deacon@....com, horms@...ge.net.au, magnus.damm@...il.com,
linux-renesas-soc@...r.kernel.org, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de,
fabio.estevam@....com, linux-imx@....com, wang.yi59@....com.cn
Subject: Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference by
addingmissing of_node_put
On Fri, Mar 01, 2019 at 04:56:53PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Cc: Liviu Dudau <liviu.dudau@....com>
> Cc: Sudeep Holla <sudeep.holla@....com>
Looks good, assuming you want to take this as a series. Please shout if
you want us to take this.
Acked-by: Sudeep Holla <sudeep.holla@....com>
--
Regards,
Sudeep
Powered by blists - more mailing lists