linux-kernel - Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190304144848.GK30476@krava>
Date:   Mon, 4 Mar 2019 15:48:48 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        jolsa@...nel.org, namhyung@...nel.org, eranian@...gle.com
Subject: Re: [PATCH 11/11] perf tools report: Implement browsing of
 individual samples

On Mon, Feb 25, 2019 at 05:33:35AM -0800, Andi Kleen wrote:
> On Mon, Feb 25, 2019 at 01:56:15PM +0100, Jiri Olsa wrote:
> > On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > +static void hists__res_sample(struct hist_entry *he, struct perf_sample *sample)
> > > +{
> > > +	struct res_sample *r;
> > > +	int j;
> > > +
> > > +	if (!he->res_samples) {
> > > +		he->res_samples = calloc(sizeof(struct res_sample),
> > > +					symbol_conf.res_sample);
> > > +		if (!he->res_samples)
> > > +			return;
> > > +	}
> > > +	if (he->num_res < symbol_conf.res_sample) {
> > > +		j = he->num_res++;
> > > +	} else {
> > > +		j = random_max(++he->num_res + 1);
> > 
> > will he->num_res keep raising all the time?
> 
> Yes, but the display code limits it to symbol_conf.res_samples
> 
> That was intentional so that we can keep track of the total
> number of samples. Plan was to eventually display it somewhere
> so that the users know how many of the samples are covered
> (currently it is not though) 

if it's not use please change it, so it's not confusing
also there's hist_entry::stat.nr_events for that

jirka