linux-kernel - Re: [PATCH V2] cros_ec: Expose sysfile to force battery cut-off on shutdown.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Mar 2019 22:58:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     RaviChandra Sadineni <ravisadineni@...omium.org>
Cc:     kbuild-all@...org, ravisadineni@...omium.org,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org, tbroch@...gle.com, dnojiri@...gle.com
Subject: Re: [PATCH V2] cros_ec: Expose sysfile to force battery cut-off on
 shutdown.

Hi RaviChandra,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0]
[cannot apply to next-20190301]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/RaviChandra-Sadineni/cros_ec-Expose-sysfile-to-force-battery-cut-off-on-shutdown/20190304-220513
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=6.4.0 make.cross ARCH=nds32 

All error/warnings (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_sysfs.c:369:3: error: 'dev_attr_cutoff_battery_at_shutdown' undeclared here (not in a function)
     &dev_attr_cutoff_battery_at_shutdown.attr,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/platform/chrome/cros_ec_sysfs.c:24:0:
   include/linux/device.h:602:26: warning: 'dev_attr_cutoff_at_shutdown' defined but not used [-Wunused-variable]
     struct device_attribute dev_attr_##_name = __ATTR_WO(_name)
                             ^
>> drivers/platform/chrome/cros_ec_sysfs.c:366:8: note: in expansion of macro 'DEVICE_ATTR_WO'
    static DEVICE_ATTR_WO(cutoff_at_shutdown);
           ^~~~~~~~~~~~~~

vim +/dev_attr_cutoff_battery_at_shutdown +369 drivers/platform/chrome/cros_ec_sysfs.c

   361	
   362	static DEVICE_ATTR_RW(reboot);
   363	static DEVICE_ATTR_RO(version);
   364	static DEVICE_ATTR_RO(flashinfo);
   365	static DEVICE_ATTR_RW(kb_wake_angle);
 > 366	static DEVICE_ATTR_WO(cutoff_at_shutdown);
   367	
   368	static struct attribute *__ec_attrs[] = {
 > 369		&dev_attr_cutoff_battery_at_shutdown.attr,
   370		&dev_attr_kb_wake_angle.attr,
   371		&dev_attr_reboot.attr,
   372		&dev_attr_version.attr,
   373		&dev_attr_flashinfo.attr,
   374		NULL,
   375	};
   376	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49917 bytes)