linux-kernel - Re: [PATCH] vfs: Move kernel_read_file() to fs/read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12096.1551716540@warthog.procyon.org.uk>
Date:   Mon, 04 Mar 2019 16:22:20 +0000
From:   David Howells <dhowells@...hat.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        linux-fsdevel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: Move kernel_read_file() to fs/read_write.c

Mimi Zohar <zohar@...ux.ibm.com> wrote:

> > Move kernel_read_file() to fs/read_write.c and out of fs/exec.c as it's not
> > actually used by anything in the execve subsystem.
> 
> All files being opened by the kernel should be calling one of these
> helper routines.  Has that changed?

prepare_binprm() uses kernel_read() and has done since at least 2014.  The
binfmt drivers also use kernel_read().

Since kernel_read_file() is used by a bunch of things that aren't exec, even
if we switch exec to it, it should probably still go in fs/read_write.c since
it seems generic.

David