[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKwvOdm4uCWCtSMVQDVTSKavpT0dCo+ayuwvoXtewmk+ksn5sA@mail.gmail.com>
Date: Mon, 4 Mar 2019 09:59:48 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Louis Taylor <louis@...gniz.eu>, Jonathan Corbet <corbet@....net>,
pmladek@...e.com, geert+renesas@...der.be,
linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
clang-built-linux@...glegroups.com,
Jon Flatley <jflat@...omium.org>
Subject: Re: [PATCH] docs: add extra integer types to printk-formats
On Sun, Mar 3, 2019 at 12:10 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Sun, Mar 03, 2019 at 12:36:47PM +0000, Louis Taylor wrote:
> > A few commonly used integer types were absent from this table, so add
> > them.
>
> I'm not against the patch, but isn't obvious by reading POSIX and / or man
> printf(3)?
You'd think; but based on the sheer number of -Wformat warnings
(~450), I'm not so sure. At least with this patch they're "above the
fold."
The kernel also has its own format flag extensions, and does not
implement %n (for good reason), so it's better to be explicit than
imply posix or glibc compat.
--
Thanks,
~Nick Desaulniers
Powered by blists - more mailing lists