linux-kernel - Re: [EXT] Re: [PATCH 2/2] mtd: spinand: micron: Support for all Micron SPI NAND flashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190304191349.71f8b147@xps13>
Date:   Mon, 4 Mar 2019 19:13:49 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com>
Cc:     Boris Brezillon <bbrezillon@...nel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chuanhong Guo <gch981213@...il.com>,
        "Richard Weinberger" <richard@....at>,
        Schrempf Frieder <frieder.schrempf@...tron.De>,
        Marek Vasut <marek.vasut@...il.com>,
        Frieder Schrempf <frieder.schrempf@...eet.de>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        "Bean Huo (beanhuo)" <beanhuo@...ron.com>
Subject: Re: [EXT] Re: [PATCH 2/2] mtd: spinand: micron: Support for all
 Micron SPI NAND flashes

Hello,

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com> wrote on
Mon, 4 Mar 2019 13:29:21 +0000:

> Hi Boris,
> 
> > -----Original Message-----
> > From: Boris Brezillon <bbrezillon@...nel.org>
> > Sent: Monday, February 4, 2019 7:02 PM
> > To: Shivamurthy Shastri (sshivamurthy) <sshivamurthy@...ron.com>
> > Cc: Miquel Raynal <miquel.raynal@...tlin.com>; linux-
> > mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; Chuanhong Guo
> > <gch981213@...il.com>; Richard Weinberger <richard@....at>; Schrempf
> > Frieder <frieder.schrempf@...tron.De>; Marek Vasut
> > <marek.vasut@...il.com>; Frieder Schrempf
> > <frieder.schrempf@...eet.de>; Brian Norris
> > <computersforpeace@...il.com>; David Woodhouse
> > <dwmw2@...radead.org>; Bean Huo (beanhuo) <beanhuo@...ron.com>
> > Subject: [EXT] Re: [PATCH 2/2] mtd: spinand: micron: Support for all Micron
> > SPI NAND flashes
> > 
> > Hi Shivamurthy,
> > 
> > On Mon, 4 Feb 2019 11:17:51 +0000
> > "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com> wrote:
> >   
> > > Driver is redesigned using parameter page to support all the Micron
> > > SPI NAND flashes.  
> > 
> > Do all Micron SPI NANDs really expose a valid ONFI param page? If
> > that's not the case, then relying on ONFi parsing only sounds like a
> > bad idea.  
> 
> Micron SPI NAND datasheet does not confirm to be as ONFI standard.
> However, they all expose parameter page, which I used for development.
> 
> >   
> > >
> > > Parameter page of Micron flashes is similar to ONFI parameter table and
> > > functionality is same, so copied some of the common functions like crc16
> > > and bit_wise_majority from nand_onfi.c.  
> > 
> > Most of the code is generic and does not depend on the spinand layer,
> > plus, we already have ONFI param page parsing code in
> > drivers/mtd/nand/raw/ which you're intentionally duplicating in a
> > version that will not be re-usable by the raw NAND layer even after
> > converting it to use the generic NAND layer.
> > 
> > Please move ONFi parsing code to drivers/mtd/nand/onfi.c and make it
> > generic.  
> 
> As I said before, it is not compliant to ONFI standard, I think it is better not 
> to make it generic.

For what I see it is too similar to copy all that code. I agree with
Boris. If there are some specificities that are not in the ONFI
standard you can do some late changes in the parameter page from
Micron's driver I guess?


Thanks,
Miquèl