linux-kernel - Re: [LKP] [workqueue] 4d43d395fe: WARNING:at_kernel/workqueue.c:#__flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b0a949b-4696-bb38-6c86-a8f5ff2e1513@gmail.com>
Date:   Mon, 4 Mar 2019 10:38:26 -0800
From:   James Smart <jsmart2021@...il.com>
To:     Sagi Grimberg <sagi@...mberg.me>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Jens Axboe <axboe@...nel.dk>,
        Keith Busch <keith.busch@...el.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>
Cc:     kernel test robot <rong.a.chen@...el.com>,
        Tejun Heo <tj@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>, lkp@...org
Subject: Re: [LKP] [workqueue] 4d43d395fe:
 WARNING:at_kernel/workqueue.c:#__flush_work

On 3/4/2019 10:21 AM, Sagi Grimberg wrote:
> 
>> Forwarding to NMVE people:
>>
>> kernel test robot found that
>> flush_work(&ctrl->async_event_work) is called from nvmet_ctrl_free()
>> without INIT_WORK(&ctrl->async_event_work, nvmet_async_event_work)
>> after ctrl was allocated (probably initialized with 0).
>> Will you make sure that INIT_WORK() is always called?
> 
> I cannot reproduce this issue. When following the code I don't
> immediately see how this can happen.. Was there something special
> in this specific test run? Is it 100% reproduce-able?

I agree. INIT_WORK is setup as almost one of the first items for a new 
controller.  Smells more like a double-free or a corrupt ctrl struct 
from the transport.

-- james