linux-kernel - RE: [PATCH] media: staging/intel-ipu3: mark PM function as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EE45BB6704246A4E914B70E8B61FB42A15C13194@SHSMSX104.ccr.corp.intel.com>
Date:   Tue, 5 Mar 2019 00:09:30 +0000
From:   "Cao, Bingbu" <bingbu.cao@...el.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "Zhi, Yong" <yong.zhi@...el.com>, Tomasz Figa <tfiga@...omium.org>,
        "Qiu, Tian Shu" <tian.shu.qiu@...el.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] media: staging/intel-ipu3: mark PM function as
 __maybe_unused

Hi, Bergmann,

Thanks for your patch.
Reviewed-by: Cao, Bingbu <bingbu.cao@...el.com>

__________________________
BRs,
Cao, Bingbu


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: Tuesday, March 5, 2019 4:29 AM
> To: Sakari Ailus <sakari.ailus@...ux.intel.com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Arnd Bergmann <arnd@...db.de>; Zhi, Yong <yong.zhi@...el.com>;
> Tomasz Figa <tfiga@...omium.org>; Qiu, Tian Shu
> <tian.shu.qiu@...el.com>; Cao, Bingbu <bingbu.cao@...el.com>; linux-
> media@...r.kernel.org; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] media: staging/intel-ipu3: mark PM function as
> __maybe_unused
> 
> The imgu_rpm_dummy_cb() looks like an API misuse that is explained in
> the comment above it. Aside from that, it also causes a warning when
> power management support is disabled:
> 
> drivers/staging/media/ipu3/ipu3.c:794:12: error: 'imgu_rpm_dummy_cb'
> defined but not used [-Werror=unused-function]
> 
> The warning is at least easy to fix by marking the function as
> __maybe_unused.
> 
> Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci
> device driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/staging/media/ipu3/ipu3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3.c
> b/drivers/staging/media/ipu3/ipu3.c
> index d575ac78c8f0..d00d26264c37 100644
> --- a/drivers/staging/media/ipu3/ipu3.c
> +++ b/drivers/staging/media/ipu3/ipu3.c
> @@ -791,7 +791,7 @@ static int __maybe_unused imgu_resume(struct device
> *dev)
>   * PCI rpm framework checks the existence of driver rpm callbacks.
>   * Place a dummy callback here to avoid rpm going into error state.
>   */
> -static int imgu_rpm_dummy_cb(struct device *dev)
> +static __maybe_unused int imgu_rpm_dummy_cb(struct device *dev)
>  {
>  	return 0;
>  }
> --
> 2.20.0