| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190305044936.22267-2-dbasehore@chromium.org>
Date: Mon, 4 Mar 2019 20:49:31 -0800
From: Derek Basehore <dbasehore@...omium.org>
To: linux-kernel@...r.kernel.org
Cc: linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-doc@...r.kernel.org,
sboyd@...nel.org, mturquette@...libre.com, heiko@...ech.de,
aisheng.dong@....com, mchehab+samsung@...nel.org, corbet@....net,
jbrunet@...libre.com, Stephen Boyd <sboyd@...eaurora.org>,
Derek Basehore <dbasehore@...omium.org>
Subject: [PATCH v2 1/6] clk: Remove recursion in clk_core_{prepare,enable}()
From: Stephen Boyd <sboyd@...eaurora.org>
Enabling and preparing clocks can be written quite naturally with
recursion. We start at some point in the tree and recurse up the
tree to find the oldest parent clk that needs to be enabled or
prepared. Then we enable/prepare and return to the caller, going
back to the clk we started at and enabling/preparing along the
way. This also unroll the recursion in unprepare,disable which can
just be done in the order of walking up the clk tree.
The problem is recursion isn't great for kernel code where we
have a limited stack size. Furthermore, we may be calling this
code inside clk_set_rate() which also has recursion in it, so
we're really not looking good if we encounter a tall clk tree.
Let's create a stack instead by looping over the parent chain and
collecting clks of interest. Then the enable/prepare becomes as
simple as iterating over that list and calling enable.
Modified verison of https://lore.kernel.org/patchwork/patch/814369/
-Fixed kernel warning
-unrolled recursion in unprepare/disable too
Cc: Jerome Brunet <jbrunet@...libre.com>
Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
Signed-off-by: Derek Basehore <dbasehore@...omium.org>
---
drivers/clk/clk.c | 191 ++++++++++++++++++++++++++--------------------
1 file changed, 107 insertions(+), 84 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index d2477a5058ac..94b3ac783d90 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -68,6 +68,8 @@ struct clk_core {
struct hlist_head children;
struct hlist_node child_node;
struct hlist_head clks;
+ struct list_head prepare_list;
+ struct list_head enable_list;
unsigned int notifier_count;
#ifdef CONFIG_DEBUG_FS
struct dentry *dentry;
@@ -677,34 +679,34 @@ static void clk_core_unprepare(struct clk_core *core)
{
lockdep_assert_held(&prepare_lock);
- if (!core)
- return;
-
- if (WARN(core->prepare_count == 0,
- "%s already unprepared\n", core->name))
- return;
-
- if (WARN(core->prepare_count == 1 && core->flags & CLK_IS_CRITICAL,
- "Unpreparing critical %s\n", core->name))
- return;
+ while (core) {
+ if (WARN(core->prepare_count == 0,
+ "%s already unprepared\n", core->name))
+ return;
- if (core->flags & CLK_SET_RATE_GATE)
- clk_core_rate_unprotect(core);
+ if (WARN(core->prepare_count == 1 &&
+ core->flags & CLK_IS_CRITICAL,
+ "Unpreparing critical %s\n", core->name))
+ return;
- if (--core->prepare_count > 0)
- return;
+ if (core->flags & CLK_SET_RATE_GATE)
+ clk_core_rate_unprotect(core);
- WARN(core->enable_count > 0, "Unpreparing enabled %s\n", core->name);
+ if (--core->prepare_count > 0)
+ return;
- trace_clk_unprepare(core);
+ WARN(core->enable_count > 0, "Unpreparing enabled %s\n",
+ core->name);
+ trace_clk_unprepare(core);
- if (core->ops->unprepare)
- core->ops->unprepare(core->hw);
+ if (core->ops->unprepare)
+ core->ops->unprepare(core->hw);
- clk_pm_runtime_put(core);
+ clk_pm_runtime_put(core);
- trace_clk_unprepare_complete(core);
- clk_core_unprepare(core->parent);
+ trace_clk_unprepare_complete(core);
+ core = core->parent;
+ }
}
static void clk_core_unprepare_lock(struct clk_core *core)
@@ -737,49 +739,57 @@ EXPORT_SYMBOL_GPL(clk_unprepare);
static int clk_core_prepare(struct clk_core *core)
{
int ret = 0;
+ LIST_HEAD(head);
lockdep_assert_held(&prepare_lock);
- if (!core)
- return 0;
+ while (core) {
+ list_add(&core->prepare_list, &head);
+ /*
+ * Stop once we see a clk that is already prepared. Adding a clk
+ * to the list with a non-zero prepare count (or reaching NULL)
+ * makes error handling work as implemented.
+ */
+ if (core->prepare_count)
+ break;
+ core = core->parent;
+ }
- if (core->prepare_count == 0) {
- ret = clk_pm_runtime_get(core);
- if (ret)
- return ret;
+ /* First entry has either a prepare_count of 0 or a NULL parent. */
+ list_for_each_entry(core, &head, prepare_list) {
+ if (core->prepare_count == 0) {
+ ret = clk_pm_runtime_get(core);
+ if (ret)
+ goto unprepare_parent;
- ret = clk_core_prepare(core->parent);
- if (ret)
- goto runtime_put;
+ trace_clk_prepare(core);
- trace_clk_prepare(core);
+ if (core->ops->prepare)
+ ret = core->ops->prepare(core->hw);
- if (core->ops->prepare)
- ret = core->ops->prepare(core->hw);
+ trace_clk_prepare_complete(core);
- trace_clk_prepare_complete(core);
+ if (ret)
+ goto runtime_put;
+ }
+ core->prepare_count++;
- if (ret)
- goto unprepare;
+ /*
+ * CLK_SET_RATE_GATE is a special case of clock protection
+ * Instead of a consumer claiming exclusive rate control, it is
+ * actually the provider which prevents any consumer from making
+ * any operation which could result in a rate change or rate
+ * glitch while the clock is prepared.
+ */
+ if (core->flags & CLK_SET_RATE_GATE)
+ clk_core_rate_protect(core);
}
- core->prepare_count++;
-
- /*
- * CLK_SET_RATE_GATE is a special case of clock protection
- * Instead of a consumer claiming exclusive rate control, it is
- * actually the provider which prevents any consumer from making any
- * operation which could result in a rate change or rate glitch while
- * the clock is prepared.
- */
- if (core->flags & CLK_SET_RATE_GATE)
- clk_core_rate_protect(core);
-
return 0;
-unprepare:
- clk_core_unprepare(core->parent);
runtime_put:
clk_pm_runtime_put(core);
+unprepare_parent:
+ clk_core_unprepare(core->parent);
return ret;
}
@@ -819,27 +829,27 @@ static void clk_core_disable(struct clk_core *core)
{
lockdep_assert_held(&enable_lock);
- if (!core)
- return;
-
- if (WARN(core->enable_count == 0, "%s already disabled\n", core->name))
- return;
-
- if (WARN(core->enable_count == 1 && core->flags & CLK_IS_CRITICAL,
- "Disabling critical %s\n", core->name))
- return;
+ while (core) {
+ if (WARN(core->enable_count == 0, "%s already disabled\n",
+ core->name))
+ return;
- if (--core->enable_count > 0)
- return;
+ if (--core->enable_count > 0)
+ return;
- trace_clk_disable_rcuidle(core);
+ if (WARN(core->enable_count == 1 &&
+ core->flags & CLK_IS_CRITICAL,
+ "Disabling critical %s\n", core->name))
+ return;
- if (core->ops->disable)
- core->ops->disable(core->hw);
+ trace_clk_disable_rcuidle(core);
- trace_clk_disable_complete_rcuidle(core);
+ if (core->ops->disable)
+ core->ops->disable(core->hw);
- clk_core_disable(core->parent);
+ trace_clk_disable_complete_rcuidle(core);
+ core = core->parent;
+ }
}
static void clk_core_disable_lock(struct clk_core *core)
@@ -875,37 +885,48 @@ EXPORT_SYMBOL_GPL(clk_disable);
static int clk_core_enable(struct clk_core *core)
{
int ret = 0;
+ LIST_HEAD(head);
lockdep_assert_held(&enable_lock);
- if (!core)
- return 0;
+ while (core) {
+ if (WARN(core->prepare_count == 0,
+ "Enabling unprepared %s\n", core->name))
+ return -ESHUTDOWN;
- if (WARN(core->prepare_count == 0,
- "Enabling unprepared %s\n", core->name))
- return -ESHUTDOWN;
-
- if (core->enable_count == 0) {
- ret = clk_core_enable(core->parent);
+ list_add(&core->enable_list, &head);
+ /*
+ * Stop once we see a clk that is already enabled. Adding a clk
+ * to the list with a non-zero prepare count (or reaching NULL)
+ * makes error handling work as implemented.
+ */
+ if (core->enable_count)
+ break;
- if (ret)
- return ret;
+ core = core->parent;
+ }
- trace_clk_enable_rcuidle(core);
+ /* First entry has either an enable_count of 0 or a NULL parent. */
+ list_for_each_entry(core, &head, enable_list) {
+ if (core->enable_count == 0) {
+ trace_clk_enable_rcuidle(core);
- if (core->ops->enable)
- ret = core->ops->enable(core->hw);
+ if (core->ops->enable)
+ ret = core->ops->enable(core->hw);
- trace_clk_enable_complete_rcuidle(core);
+ trace_clk_enable_complete_rcuidle(core);
- if (ret) {
- clk_core_disable(core->parent);
- return ret;
+ if (ret)
+ goto err;
}
+
+ core->enable_count++;
}
- core->enable_count++;
return 0;
+err:
+ clk_core_disable(core->parent);
+ return ret;
}
static int clk_core_enable_lock(struct clk_core *core)
@@ -3288,6 +3309,8 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw)
core->num_parents = hw->init->num_parents;
core->min_rate = 0;
core->max_rate = ULONG_MAX;
+ INIT_LIST_HEAD(&core->prepare_list);
+ INIT_LIST_HEAD(&core->enable_list);
hw->core = core;
/* allocate local copy in case parent_names is __initdata */
--
2.21.0.352.gf09ad66450-goog
Powered by blists - more mailing lists