linux-kernel - [PATCH v2] scripts: checkpatch: Check multiple blank lines when deleting code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190305071251.28427-1-alex@ghiti.fr>
Date:   Tue,  5 Mar 2019 02:12:51 -0500
From:   Alexandre Ghiti <alex@...ti.fr>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        linux-kernel@...r.kernel.org
Cc:     Alexandre Ghiti <alex@...ti.fr>
Subject: [PATCH v2] scripts: checkpatch: Check multiple blank lines when deleting code

By matching only current line starting with '+', we miss the case
when deleting code makes consecutive blank lines appear: this patch
then makes it possible to detect this case by also matching current
line starting with ' ', which is an already existing blank line.

Signed-off-by: Alexandre Ghiti <alex@...ti.fr>
---

Changes in v2:
	- Fix the --fix option

 scripts/checkpatch.pl | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b737ca9d7204..7dc12c137009 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2081,10 +2081,15 @@ sub fix_inserted_deleted_lines {
 		}
 
 		while (defined($inserted) && ${$inserted}{'LINENR'} == $old_linenr) {
+			my $len = 1;
 			push(@lines, ${$inserted}{'LINE'});
+			# Do not increment the length when inserting a deletion line.
+			if (${$inserted}{'LINE'} =~ /^\-/) {
+				$len = 0;
+			}
 			$inserted = @{$insertedRef}[$next_insert++];
 			$new_linenr++;
-			fixup_current_range(\$lines[$range_last_linenr], $delta_offset++, 1);
+			fixup_current_range(\$lines[$range_last_linenr], $delta_offset++, $len);
 		}
 
 		if ($save_line) {
@@ -3298,12 +3303,18 @@ sub process {
 
 # check for multiple consecutive blank lines
 		if ($prevline =~ /^[\+ ]\s*$/ &&
-		    $line =~ /^\+\s*$/ &&
+		    $line =~ /^[\+ ]\s*$/ &&
 		    $last_blank_line != ($linenr - 1)) {
 			if (CHK("LINE_SPACING",
 				"Please don't use multiple blank lines\n" . $hereprev) &&
 			    $fix) {
 				fix_delete_line($fixlinenr, $rawline);
+				if ($line =~ /^ \s*$/) {
+					# If the line is not an inserted blank line, the multiple
+					# consecutive blank lines are caused by deletion: fix this
+					# by replacing the blank line with a deletion line.
+					fix_insert_line($fixlinenr, "\-");
+				}
 			}
 
 			$last_blank_line = $linenr;
-- 
2.20.1