linux-kernel - Re: [PATCH] drivers: x86: pcengines-apuv2: fix dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14e2b3bd-b3cd-54f2-e8c6-73c81e89e456@infradead.org>
Date:   Mon, 4 Mar 2019 16:34:09 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org
Cc:     linux-gpio@...r.kernel.org, linus.walleij@...aro.org,
        andy.shevchenko@...il.com, arnd@...db.de
Subject: Re: [PATCH] drivers: x86: pcengines-apuv2: fix dependencies

On 3/4/19 4:24 PM, Enrico Weigelt, metux IT consult wrote:
> pcengines-apuv2 board driver needs to explicitly select LEDS_CLASS,
> INPUT, INPUT_KEYBOARD, so these are automatically defined correctly
> (eg. LEDS_CLASS=y if PCENGINES_APU2=y)
> 
> Cc: linux-gpio@...r.kernel.org
> Cc: linus.walleij@...aro.org
> Cc: andy.shevchenko@...il.com
> Cc: arnd@...db.de
> Cc: rdunlap@...radead.org
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: arnd@...db.de
> Reported-by: rdunlap@...radead.org
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/platform/x86/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 851ea92..7d53380 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1307,7 +1307,10 @@ config PCENGINES_APU2
>  	tristate "PC Engines APUv2/3 front button and LEDs driver"
>  	select GPIO_AMD_FCH
>  	select KEYBOARD_GPIO_POLLED
> +	select LEDS_CLASS
>  	select LEDS_GPIO
> +	select INPUT

Nak.  We don't select entire subsystems.  You should do:

	depends on INPUT
	select INPUT_KEYBOARD

> +	select INPUT_KEYBOARD


>  	help
>  	  This driver provides support for the front button and LEDs on
>  	  PC Engines APUv2/APUv3 board.
> 


-- 
~Randy