linux-kernel - Re: [PATCH 3/3] x86: apuv2: select LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24c191e1-f607-1320-2474-3db92383e383@metux.net>
Date:   Tue, 5 Mar 2019 01:03:14 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Arnd Bergmann <arnd@...db.de>, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Linus Walleij <linusw@...nel.org>, Enrico Weigelt <info@...ux.net>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-gpio@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86: apuv2: select LEDS_CLASS

On 04.03.19 21:19, Arnd Bergmann wrote:
> LEDS_GPIO can only be selected when LEDS_CLASS is already enabled:
> 
> WARNING: unmet direct dependencies detected for LEDS_GPIO
>   Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
>   Selected by [y]:
>   - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && INPUT_KEYBOARD [=y]
> 
> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 4d65d37b0c86..d64529352a9c 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1308,6 +1308,7 @@ config PCENGINES_APU2
>  	depends on INPUT && INPUT_KEYBOARD
>  	select GPIO_AMD_FCH
>  	select KEYBOARD_GPIO_POLLED
> +	select LEDS_CLASS
>  	select LEDS_GPIO
>  	help
>  	  This driver provides support for the front button and LEDs on
> 

ACK. Just was about to post the same :)

Reviewed-by: Enrico Weigelt, metux It consult <info@...ux.net>


thx.

--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287