linux-kernel - Re: [PATCH v6 1/4] can: m_can: Create a m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fafe78cbb34dc8acd31f873bcd55af879311d839.camel@perches.com>
Date:   Mon, 04 Mar 2019 18:48:58 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dan Murphy <dmurphy@...com>,
        Wolfgang Grandegger <wg@...ndegger.com>, mkl@...gutronix.de,
        davem@...emloft.net
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

On Mon, 2019-03-04 at 13:12 -0600, Dan Murphy wrote:
> On 3/4/19 12:13 PM, Wolfgang Grandegger wrote:
> > Am 04.03.19 um 18:22 schrieb Dan Murphy:
> > > > > +	int pm_clock_support;
> > > > 
> > > > A "bool" would be more appropriate, I think.
> > > 
> > > I was abiding by this checkpatch warning I got on the is_peripherial.
> > > 
> > > CHECK: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
> > > #94: FILE: drivers/net/can/m_can/m_can.h:94:
> > > +	bool is_peripherial;
> > > 
> > 
> > Ah, right! I was also surprised to get that warning. The kernel is full
> > of bool's, but well, we should make "checkpatch" happy (and Linus).

That check has been removed from checkpatch by

commit 7967656ffbfa493f5546c0f18bf8a28f702c4baa
Author: Jason Gunthorpe <jgg@...pe.ca>
Date:   Fri Jan 18 15:50:47 2019 -0700

    coding-style: Clarify the expectations around bool
    
    There has been some confusion since checkpatch started warning about bool
    use in structures, and people have been avoiding using it.
    
    Many people feel there is still a legitimate place for bool in structures,
    so provide some guidance on bool usage derived from the entire thread that
    spawned the checkpatch warning.
    
    Link: https://lkml.kernel.org/r/CA+55aFwVZk1OfB9T2v014PTAKFhtVan_Zj2dOjnCy3x6E4UJfA@mail.gmail.com