linux-kernel - Re: [PATCH] media: drxk: add a missed check of the return value of write16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190305211647.srkivgazz37vvfqn@gofer.mess.org>
Date:   Tue, 5 Mar 2019 21:16:48 +0000
From:   Sean Young <sean@...s.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Mauro Carvalho Chehab <mchehab@...nel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Peter Rosin <peda@...ntia.se>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: drxk: add a missed check of the return value of
 write16

On Tue, Dec 25, 2018 at 02:03:07AM -0600, Kangjie Lu wrote:
> write16() could fail. The fix inserts a check for its return value
> in case it fails.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

Unless it is tested on the actual hardware we can't apply this. This could
introduce regressions.

Sean

> ---
>  drivers/media/dvb-frontends/drxk_hard.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
> index 84ac3f73f8fe..b7579ffae690 100644
> --- a/drivers/media/dvb-frontends/drxk_hard.c
> +++ b/drivers/media/dvb-frontends/drxk_hard.c
> @@ -6610,7 +6610,9 @@ static int drxk_get_stats(struct dvb_frontend *fe)
>  	if (status < 0)
>  		goto error;
>  	pkt_error_count = reg16;
> -	write16(state, SCU_RAM_FEC_ACCUM_PKT_FAILURES__A, 0);
> +	status = write16(state, SCU_RAM_FEC_ACCUM_PKT_FAILURES__A, 0);
> +	if (status < 0)
> +		goto error;
>  
>  	post_bit_err_count *= post_bit_error_scale;
>  
> -- 
> 2.17.2 (Apple Git-113)