linux-kernel - Re: [PATCH 08/14] Move EM_NDS32 to uapi/linux/elf-em.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 14:27:55 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Vincent Chen <deanbo422@...il.com>
Cc:     "Dmitry V. Levin" <ldv@...linux.org>,
        Elvira Khabirova <lineprinter@...linux.org>,
        Eugene Syromyatnikov <esyr@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Paul Moore <paul@...l-moore.com>, linux-audit@...hat.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/14] Move EM_NDS32 to uapi/linux/elf-em.h

Vincent Chen <deanbo422@...il.com> 於 2019年3月5日 週二 上午8:26寫道：
>
> Dmitry V. Levin <ldv@...linux.org> 於 2019年2月27日 週三 下午11:30寫道：
>
>
> >
> > This should never have been defined in the arch tree to begin with,
> > and now uapi/linux/audit.h header is going to use EM_NDS32
> > in order to define AUDIT_ARCH_NDS32 which is needed to implement
> > syscall_get_arch() which in turn is required to extend
> > the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.
> >
> > Acked-by: Paul Moore <paul@...l-moore.com>
> > Cc: Greentime Hu <green.hu@...il.com>
> > Cc: Vincent Chen <deanbo422@...il.com>
> > Cc: Elvira Khabirova <lineprinter@...linux.org>
> > Cc: Eugene Syromyatnikov <esyr@...hat.com>
> > Cc: Oleg Nesterov <oleg@...hat.com>
> > Cc: Andy Lutomirski <luto@...nel.org>
> > Cc: linux-audit@...hat.com
> > Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> > ---
> >  This is just a gentle ping, the patch is unchanged.
> >
> >  arch/nds32/include/asm/elf.h | 3 +--
> >  include/uapi/linux/elf-em.h  | 2 ++
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/nds32/include/asm/elf.h b/arch/nds32/include/asm/elf.h
> > index 95f3ea253e4c..02250626b9f0 100644
> > --- a/arch/nds32/include/asm/elf.h
> > +++ b/arch/nds32/include/asm/elf.h
> > @@ -10,14 +10,13 @@
> >
> >  #include <asm/ptrace.h>
> >  #include <asm/fpu.h>
> > +#include <linux/elf-em.h>
> >
> >  typedef unsigned long elf_greg_t;
> >  typedef unsigned long elf_freg_t[3];
> >
> >  extern unsigned int elf_hwcap;
> >
> > -#define EM_NDS32                       167
> > -
> >  #define R_NDS32_NONE                   0
> >  #define R_NDS32_16_RELA                        19
> >  #define R_NDS32_32_RELA                        20
> > diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h
> > index bd02325028d8..4b8df722330e 100644
> > --- a/include/uapi/linux/elf-em.h
> > +++ b/include/uapi/linux/elf-em.h
> > @@ -40,6 +40,8 @@
> >  #define EM_ALTERA_NIOS2        113     /* Altera Nios II soft-core processor */
> >  #define EM_TI_C6000    140     /* TI C6X DSPs */
> >  #define EM_HEXAGON     164     /* QUALCOMM Hexagon */
> > +#define EM_NDS32       167     /* Andes Technology compact code size
> > +                                  embedded RISC processor family */
> >  #define EM_AARCH64     183     /* ARM 64 bit */
> >  #define EM_TILEPRO     188     /* Tilera TILEPro */
> >  #define EM_MICROBLAZE  189     /* Xilinx MicroBlaze */
> > --
> > ldv
>
> Thanks for fixing this.
>
> Acked-by Vincent Chen

Thank you. I add his email address. :P

Acked-by: Vincent Chen <vincentc@...estech.com>
Acked-by: Greentime Hu <greentime@...estech.com>