lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Mar 2019 10:43:09 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Arnold J Chand <chand.arnold@...mail.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org> Subject: Re: [PATCH] staging/board/board.c: Fix compiler error of_find_all_nodes() Change the subsystem prefix to: [PATCH] Staging: board: ... On Tue, Mar 05, 2019 at 11:39:30PM +0000, Arnold J Chand wrote: > Fix implicit-function-declaration error by 'extern'-ing the function in > the file > > Signed-off-by: Arnold Chand <chand.arnold@...mail.com> > --- > drivers/staging/board/board.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c > index cb6feb34dd40..3025ee9f5517 100644 > --- a/drivers/staging/board/board.c > +++ b/drivers/staging/board/board.c > @@ -22,6 +22,8 @@ > static struct device_node *irqc_node __initdata; > static unsigned int irqc_base __initdata; > > +extern struct device_node *of_find_all_nodes(struct device_node *prev); > + We already include <linux/of.h> so what's going on here? The driver compiles for me. Anyway, fix the includes, don't do this. regards, dan carpenter
Powered by blists - more mailing lists