linux-kernel - Re: [PATCH v2] x86/gart/kcore: Exclude GART aperture from kcore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190306090307.GG14858@MiWiFi-R3L-srv>
Date:   Wed, 6 Mar 2019 17:03:07 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Kairui Song <kasong@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Jiri Bohac <jbohac@...e.cz>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Omar Sandoval <osandov@...com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Dave Young <dyoung@...hat.com>
Subject: Re: [PATCH v2] x86/gart/kcore: Exclude GART aperture from kcore

On 03/06/19 at 04:48pm, Kairui Song wrote:
> On Tue, Feb 19, 2019 at 4:00 PM Kairui Song <kasong@...hat.com> wrote:
> Hi Baoquan, after second thought, vmcore and kcore are doing similar
> thing but still quite independent of each, didn't see any simple way
> to share the logic.
> And for the following naming issue I think considering the context
> there is no problem, "exclude_from_vmcore(aper_alloc, aper_order)" is
> clearly doing what it literally means, excluding the aperture from
> vmcore.
> 
> Let me know if anything is wrong, will send V4 later reuse this approach.

Thanks for the effort.

Yes, saw your v3. I kept quiet because I personally prefer the v2 method
which is similar to vmcore handling. So if you have investigated and
decided to do v2 way after deliberate thought, feel free to post v4. I
will make time to review.

Thanks
Baoquan