linux-kernel - Re: [PATCH 13/13] regulator: wm831x ldo: Fix notifier mutex lock warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190306092821.GI46536@ediswmail.ad.cirrus.com>
Date:   Wed, 6 Mar 2019 09:28:21 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Steve Twiss <stwiss.opensource@...semi.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Support Opensource <support.opensource@...semi.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Cirrus Patches <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 13/13] regulator: wm831x ldo: Fix notifier mutex lock
 warning

On Tue, Feb 26, 2019 at 03:54:01PM +0000, Steve Twiss wrote:
> The mutex for the regulator_dev must be controlled by the caller of
> the regulator_notifier_call_chain(), as described in the comment
> for that function.
> 
> Failure to mutex lock and unlock surrounding the notifier call results
> in a kernel WARN_ON_ONCE() which will dump a backtrace for the
> regulator_notifier_call_chain() when that function call is first made.
> The mutex can be controlled using the regulator_lock/unlock() API.
> 
> Fixes: d1c6b4fe668b ("regulator: Add WM831x LDO support")
> Suggested-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles