linux-kernel - RE: [PATCH 4/4] scsi: ufs: hisi: fix ufs_hba_variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB49231ACAA50E4D8FF5BCE469FC730@DM6PR04MB4923.namprd04.prod.outlook.com>
Date:   Wed, 6 Mar 2019 11:43:24 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Arnd Bergmann <arnd@...db.de>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     Alim Akhtar <alim.akhtar@...sung.com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        Wei Li <liwei213@...wei.com>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/4] scsi: ufs: hisi: fix ufs_hba_variant_ops passing

> 
> Without CONFIG_OF, the of_match_node() helper does not evaluate
> its argument, and the compiler warns about the unused variable:
> 
> drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe':
> drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev' [-
> Werror=unused-variable]
> 
> Rework this code to pass the data directly, and while we're
> at it, correctly handle the const pointers.
> 
> Fixes: 653fcb07d95e ("scsi: ufs: Add HI3670 SoC UFS driver support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Avri Altman <avri.altman@....com>

Arnd, Thank you for your comments.
Regards,
Avri