linux-kernel - Re: [PATCH 3/3] irqchip/gic-pm: use devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573022cf-e2e3-0e12-d16c-6d465b8af2ce@nvidia.com>
Date:   Wed, 6 Mar 2019 12:00:02 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Marc Zyngier <marc.zyngier@....com>,
        Sameer Pujar <spujar@...dia.com>, <vkoul@...nel.org>,
        <dan.j.williams@...el.com>, <tglx@...utronix.de>,
        <jason@...edaemon.net>
CC:     <thierry.reding@...il.com>, <ldewangan@...dia.com>,
        <mkumard@...dia.com>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH 3/3] irqchip/gic-pm: use devm_clk_*() helpers


On 06/03/2019 11:31, Marc Zyngier wrote:
> Hi Sameer,
> 
> [unrelated to this email: anything that comes from NVIDIA reaches me
>  encrypted with my public key. Not a big deal, but it'd be good if
>  someone could fix that.]
> 
> On 06/03/2019 10:41, Sameer Pujar wrote:
>> With pm_clk_*() usage, it is seen that clocks always remain ON. This
>> happens because clocks are managed by BPMP on Tegra devices and clock
>> enable/disable happens during prepare/unprepare phase. This patch
>> avoids use of pm_clk_*() and replaces it with devm_clk_*() helpers.
>>
>> Suggested-by: Mohan Kumar D <mkumard@...dia.com>
>> Reviewed-by: Jonathan Hunter <jonathanh@...dia.com>
>> Signed-off-by: Sameer Pujar <spujar@...dia.com>
> 
> On its own, I'm not opposed to that patch.
> 
> But given that there is no in-tree platform using this, despite the code
> sitting here for more than 2.5 years, this is just updating dead code.
> 
> Am I missing anything?

Nope, but we are working to fix that at long last. I hope in the next
few months it will not longer be dormant! This driver is still very much
important to our audio support for newer Tegra devices.

Cheers
Jon

-- 
nvpublic