linux-kernel - Re: [PATCH] ipc: Fix building compat mode without sysvipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 06:44:51 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>, y2038@...ts.linaro.org
Cc:     John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipc: Fix building compat mode without sysvipc

On 3/6/19 6:29 AM, Arnd Bergmann wrote:
> As John Stultz noticed, my y2038 syscall series caused a link
> failure when CONFIG_SYSVIPC is enabled but CONFIG_COMPAT is
> enabled:
> 

is this supposed to be "CONFIG_SYSVIPC is disabled" to match the
subject?

> arch/arm64/kernel/sys32.o:(.rodata+0x960): undefined reference to `__arm64_compat_sys_old_semctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x980): undefined reference to `__arm64_compat_sys_old_msgctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x9a0): undefined reference to `__arm64_compat_sys_old_shmctl'
> 
> Add the missing entries in kernel/sys_ni.c for the new system
> calls.
> 
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I'm about to send off my pull requests for arm-soc, so I'd just
> send another one with just this common from my y2038 tree.
> ---
>   kernel/sys_ni.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 85e5ccec0955..62a6c8707799 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -202,6 +202,7 @@ COND_SYSCALL(msgget);
>   COND_SYSCALL(old_msgctl);
>   COND_SYSCALL(msgctl);
>   COND_SYSCALL_COMPAT(msgctl);
> +COND_SYSCALL_COMPAT(old_msgctl);
>   COND_SYSCALL(msgrcv);
>   COND_SYSCALL_COMPAT(msgrcv);
>   COND_SYSCALL(msgsnd);
> @@ -212,6 +213,7 @@ COND_SYSCALL(semget);
>   COND_SYSCALL(old_semctl);
>   COND_SYSCALL(semctl);
>   COND_SYSCALL_COMPAT(semctl);
> +COND_SYSCALL_COMPAT(old_semctl);
>   COND_SYSCALL(semtimedop);
>   COND_SYSCALL(semtimedop_time32);
>   COND_SYSCALL(semop);
> @@ -221,6 +223,7 @@ COND_SYSCALL(shmget);
>   COND_SYSCALL(old_shmctl);
>   COND_SYSCALL(shmctl);
>   COND_SYSCALL_COMPAT(shmctl);
> +COND_SYSCALL_COMPAT(old_shmctl);
>   COND_SYSCALL(shmat);
>   COND_SYSCALL_COMPAT(shmat);
>   COND_SYSCALL(shmdt);
>