linux-kernel - Re: [PATCH] usbip: Remove unnecessary null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d40255b3-5f87-c6a5-ebe2-c499dc858b76@kernel.org>
Date:   Wed, 6 Mar 2019 08:11:00 -0700
From:   shuah <shuah@...nel.org>
To:     Suwan Kim <suwan.kim027@...il.com>, valentina.manea.m@...il.com,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbip: Remove unnecessary null check

Hi Suwan,

On 3/5/19 8:11 AM, Suwan Kim wrote:
> "vdev" points to vhci_hcd->vdev[] array and vhci_hcd->vdev[] array
> is not a pointer array but a structure array and it is already used
> in vhci_urb_enqueue() and then passed to vhci_tx_urb() as an argument.
> vhci_tx_urb() is not called except vhci_urb_enqueue(). So, "vdev"
> can not be null pointer. This null check statement is meaningless.
> 
> Signed-off-by: Suwan Kim <suwan.kim027@...il.com>
> ---
>   drivers/usb/usbip/vhci_hcd.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index f46ee1fefe02..667d9c0ec905 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -654,15 +654,9 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>   static void vhci_tx_urb(struct urb *urb, struct vhci_device *vdev)
>   {
>   	struct vhci_priv *priv;
> -	struct vhci_hcd *vhci_hcd;
> +	struct vhci_hcd *vhci_hcd = vdev_to_vhci_hcd(vdev);
>   	unsigned long flags;
>   
> -	if (!vdev) {
> -		pr_err("could not get virtual device");
> -		return;
> -	}
> -	vhci_hcd = vdev_to_vhci_hcd(vdev);
> -
>   	priv = kzalloc(sizeof(struct vhci_priv), GFP_ATOMIC);
>   	if (!priv) {
>   		usbip_event_add(&vdev->ud, VDEV_EVENT_ERROR_MALLOC);
> 

Thanks for the patch. Looks good to me.

Acked-by: Shuah Khan <shuah@...nel.org>

thanks,
-- Shuah