linux-kernel - Re: [PATCH] net/sched: avoid unused-label warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Mar 2019 16:28:23 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Vlad Buslov <vladbu@...lanox.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Adi Nissim <adin@...lanox.com>, wenxu <wenxu@...oud.cn>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/sched: avoid unused-label warning

On Mon, Mar 4, 2019 at 12:40 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> The label is only used from inside the #ifdef and should be
> hidden the same way, to avoid this warning:
>
> net/sched/act_tunnel_key.c: In function 'tunnel_key_init':
> net/sched/act_tunnel_key.c:389:1: error: label 'release_tun_meta' defined but not used [-Werror=unused-label]
>  release_tun_meta:
>
> Fixes: 41411e2fd6b8 ("net/sched: act_tunnel_key: Add dst_cache support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/sched/act_tunnel_key.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c
> index 2a5f215ae876..3beb4717d3b7 100644
> --- a/net/sched/act_tunnel_key.c
> +++ b/net/sched/act_tunnel_key.c
> @@ -392,8 +392,8 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
>  #ifdef CONFIG_DST_CACHE
>         if (metadata)
>                 dst_cache_destroy(&metadata->u.tun_info.dst_cache);
> -#endif
>  release_tun_meta:
> +#endif

These #ifdef's are ugly, either we should select DST_CACHE
or provide a nop for these dst_cache_*() APIs when it is not
enabled.