linux-kernel - Re: [PATCH] md: Fix failed allocation of md_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4+2r+CV71JGL6_0Cxn0aDeuLDg7Bhma51tS7RpR9fZpg@mail.gmail.com>
Date:   Wed, 6 Mar 2019 08:58:04 -0800
From:   Song Liu <liu.song.a23@...il.com>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, Shaohua Li <shli@...nel.org>,
        linux-raid <linux-raid@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] md: Fix failed allocation of md_register_thread

On Mon, Mar 4, 2019 at 2:50 PM Aditya Pakki <pakki001@....edu> wrote:
>
> mddev->sync_thread can be set to NULL on kzalloc failure downstream.
> The patch checks for such a scenario and frees allocated resources.
>
> Signed-off-by: Aditya Pakki <pakki001@....edu>

This looks good. Could you please add a "Fixed:" tag?

Thanks,
Song

> ---
>  drivers/md/raid10.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index abb5d382f64d..f52b4d9bcd24 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3939,6 +3939,8 @@ static int raid10_run(struct mddev *mddev)
>                 set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
>                 mddev->sync_thread = md_register_thread(md_do_sync, mddev,
>                                                         "reshape");
> +               if (!mddev->sync_thread)
> +                       goto out_free_conf;
>         }
>
>         return 0;
> --
> 2.17.1
>