linux-kernel - Re: [PATCH net] net: hsr: fix memory leak in hsr_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 Mar 2019 10:57:32 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        arvid.brodin@...en.se
Subject: Re: [PATCH net] net: hsr: fix memory leak in hsr_dev_finalize()

From: Mao Wenan <maowenan@...wei.com>
Date: Wed, 6 Mar 2019 22:45:01 +0800

> If hsr_add_port(hsr, hsr_dev, HSR_PT_MASTER) failed to
> add port, it directly returns res and forgets to free the node
> that allocated in hsr_create_self_node(), and forgets to delete
> the node->mac_list linked in hsr->self_node_db.
 ...
> Fixes: c5a759117210("net/hsr: Use list_head (and rcu) instead of array for slave devices.")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

Applied and queued up for -stable, thanks.