linux-kernel - Re: [PATCH] x86/unwind/orc: Fix ORC unwind table alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 13:04:57 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dmitry Golovin <dima@...ovin.in>,
        Sedat Dilek <sedat.dilek@...il.com>
Subject: Re: [PATCH] x86/unwind/orc: Fix ORC unwind table alignment

On Wed, Mar 06, 2019 at 10:44:01AM -0800, Nick Desaulniers wrote:
> On Wed, Mar 6, 2019 at 9:08 AM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> >
> > The .orc_unwind section is a packed array of 6-byte structs.  It's
> > currently aligned to 6 bytes, which is causing warnings in the LLD
> > linker.
> >
> > Six isn't a power of two, so it's not a valid alignment value.  The
> > actual alignment doesn't matter much because it's an array of packed
> > structs.  An alignment of two is sufficient.  In reality it always gets
> > aligned to four bytes because it comes immediately after the
> > 4-byte-aligned .orc_unwind_ip section.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/218
> > Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
> 
> Thanks for the patch Josh, we appreciate it.  It looks like
> ee9f8fce9964 landed in v4.14-rc1.  Should we CC stable?

Yes, that would be a good idea.

Can the tip maintainers please add

  Cc: stable@...r.kernel.org

when merging?

-- 
Josh