lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Mar 2019 19:14:18 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Wen Yang <wen.yang99@....com.cn>, linux-kernel@...r.kernel.org Cc: wang.yi59@....com.cn, Florian Fainelli <f.fainelli@...il.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, bcm-kernel-feedback-list@...adcom.com, Russell King <linux@...linux.org.uk>, Brian Norris <computersforpeace@...il.com>, Gregory Fong <gregory.0xf0@...il.com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/4] ARM: brcmstb: fix a leaked reference by adding missing of_node_put On 3/5/2019 3:32 AM, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-bcm/platsmp-brcmstb.c:337:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this function. > ./arch/arm/mach-bcm/platsmp-brcmstb.c:341:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this functio > ./arch/arm/mach-bcm/bcm63xx_smp.c:150:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. I would actually lump that in your [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node_put patch since the subject of that one is correct. Thanks! -- Florian
Powered by blists - more mailing lists