linux-kernel - Re: [PATCH] x86/KASLR: always return a value from process_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190306203725.GA23373@gmail.com>
Date:   Wed, 6 Mar 2019 20:37:26 +0000
From:   Louis Taylor <louis@...gniz.eu>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        fanc.fnst@...fujitsu.com, bhe@...hat.com,
        kirill.shutemov@...ux.intel.com, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com, ndesaulniers@...gle.com,
        jflat@...omium.org
Subject: Re: [PATCH] x86/KASLR: always return a value from process_mem_region

On Wed, Mar 06, 2019 at 09:02:47PM +0100, Thomas Gleixner wrote:
> On Sat, 2 Mar 2019, Louis Taylor wrote:
> 
> > When compiling with -Wreturn-type, clang warns:
> > 
> > arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
> >       non-void function [-Wreturn-type]
> > 
> > This function's return statement should probably have been placed
> > outside the #endif, so move it there
> > 
> > Link: https://github.com/ClangBuiltLinux/linux/issues/360
> > Signed-off-by: Louis Taylor <louis@...gniz.eu>
> 
> This lacks a
> 
> Fixes: commitsha1 (".....")

Fixes: 690eaa532057 ("x86/boot/KASLR: Limit KASLR to extract the kernel in immovable memory only")

Would you like me to resend with that tag?

Cheers,
Louis