linux-kernel - Re: [PATCH] xfrm: Reset secpath in xfrm failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190306211536.GA27609@myunghoj-Precision-5530>
Date:   Thu, 7 Mar 2019 06:15:38 +0900
From:   Myungho Jung <mhjungk@...il.com>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfrm: Reset secpath in xfrm failure

On Wed, Mar 06, 2019 at 12:35:43PM +0100, Steffen Klassert wrote:
> On Wed, Mar 06, 2019 at 04:33:08PM +0900, Myungho Jung wrote:
> > In esp4_gro_receive() and esp6_gro_receive(), secpath can be allocated
> > without adding xfrm state to xvec. Then, sp->xvec[sp->len - 1] would
> > fail and result in dereferencing invalid pointer in esp4_gso_segment()
> > and esp6_gso_segment(). Reset secpath if xfrm function returns error.
> > 
> > Reported-by: syzbot+b69368fd933c6c592f4c@...kaller.appspotmail.com
> > Signed-off-by: Myungho Jung <mhjungk@...il.com>
> 
> The patch itself looks ok, but please add a 'Fixes' tag to
> the commit message.
> 
> Thanks!

Hi Steffen,

Thanks for reviewing the change. I'll add fixes tag and resubmit it.

Thanks,
Myungho