linux-kernel - Re: [PATCH -next & mmotm] extcon: fix EXTCON_PTP5150 kconfig warnings and build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9a85c4a4-5dc7-e69a-ffa1-490c8cb98e9f@samsung.com>
Date:   Wed, 6 Mar 2019 14:07:14 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Vijai Kumar K <vijaikumar.kanagarajan@...il.com>
Subject: Re: [PATCH -next & mmotm] extcon: fix EXTCON_PTP5150 kconfig
 warnings and build errors

Hi,

Applied it for v5.1-rc2.
I'll send the pull request it for v5.1-rc2.

Best Regards,
Chanwoo Choi

On 19. 2. 26. 오전 9:17, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Having COMPILE_TEST here is causing problems.  I reported one
> last week and have another one today.  Although I support
> using COMPILE_TEST when possible, this one is better removed.
> 
> Fixes these warnings and build errors:
> 
> WARNING: unmet direct dependencies detected for REGMAP_I2C
>   Depends on [m]: I2C [=m]
>   Selected by [y]:
>   - EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y])
>   Selected by [m]:
>   - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
>   - KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m]
>   - I2C_MUX_LTC4306 [=m] && I2C [=m] && I2C_MUX [=m]
>   - GPIO_TS4900 [=m] && GPIOLIB [=y] && I2C [=m] && (SOC_IMX6 || COMPILE_TEST [=y])
>   - SENSORS_LTC2945 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_LTC4222 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_MAX6621 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_LM75 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_NCT7802 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_EMC1403 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_ADS7828 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_INA2XX [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_INA3221 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_TMP102 [=m] && HWMON [=y] && I2C [=m]
>   - SENSORS_TMP103 [=m] && HWMON [=y] && I2C [=m]
>   - MFD_BCM590XX [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_AXP20X_I2C [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_MADERA_I2C [=m] && HAS_IOMEM [=y] && MFD_MADERA [=m] && I2C [=m]
>   - MFD_DA9062 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_DA9063 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_DA9150 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_MC13XXX_I2C [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_88PM800 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_88PM805 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_MAX14577 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_MAX77686 [=m] && HAS_IOMEM [=y] && I2C [=m] && (OF [=y] || COMPILE_TEST [=y])
>   - MFD_MAX8907 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_RT5033 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_RN5T618 [=m] && HAS_IOMEM [=y] && I2C [=m] && OF [=y]
>   - MFD_SI476X_CORE [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_SKY81452 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_TI_LMU [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - TPS6105X [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_TPS65086 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_TPS65217 [=m] && HAS_IOMEM [=y] && I2C [=m] && OF [=y]
>   - MFD_TI_LP873X [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_TPS65218 [=m] && HAS_IOMEM [=y] && I2C [=m] && OF [=y]
>   - MFD_TPS65912_I2C [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_LM3533 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - MFD_WM8994 [=m] && HAS_IOMEM [=y] && I2C [=m]
>   - REGULATOR_88PG86X [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_DA9211 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_FAN53555 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_LTC3676 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_MAX8649 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_MT6311 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_PFUZE100 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_PV88060 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_PV88080 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_SY8106A [=m] && REGULATOR [=y] && I2C [=m] && (OF [=y] || COMPILE_TEST [=y])
>   - REGULATOR_TPS62360 [=m] && REGULATOR [=y] && I2C [=m]
>   - REGULATOR_TPS65023 [=m] && REGULATOR [=y] && I2C [=m]
>   - DRM_ANALOGIX_ANX78XX [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y]
>   - DRM_TOSHIBA_TC358767 [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
>   - DRM_TI_SN65DSI86 [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
>   - DRM_I2C_ADV7511 [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
>   - BACKLIGHT_LM3630A [=m] && HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=y] && BACKLIGHT_CLASS_DEVICE [=m] && I2C [=m] && PWM [=y]
>   - BACKLIGHT_LM3639 [=m] && HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=y] && BACKLIGHT_CLASS_DEVICE [=m] && I2C [=m]
>   - LEDS_LM3642 [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=m]
>   - LEDS_LP8860 [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=m] && OF [=y]
>   - LEDS_TLC591XX [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=m]
>   - LEDS_LM355x [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=m]
>   - LEDS_IS31FL319X [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=m] && OF [=y]
>   - EXTCON_RT8973A [=m] && EXTCON [=y] && I2C [=m]
>   - ADXL345_I2C [=m] && IIO [=y] && INPUT_ADXL34X [=n]=n && I2C [=m]
>   - BMC150_ACCEL_I2C [=m] && IIO [=y]
>   - MMA7455_I2C [=m] && IIO [=y] && I2C [=m]
>   - MXC4005 [=m] && IIO [=y] && I2C [=m]
>   - MXC6255 [=m] && IIO [=y] && I2C [=m]
>   - TI_ADS1015 [=m] && IIO [=y] && I2C [=m] && !SENSORS_ADS1015 [=n]
>   - BME680_I2C [=m] && IIO [=y] && I2C [=m] && BME680 [=m]
>   - AD5380 [=m] && IIO [=y] && (SPI_MASTER [=n] && I2C [=m]!=m || I2C [=m]) && I2C [=m]
>   - BMG160_I2C [=m] && IIO [=y]
>   - MPU3050_I2C [=m] && IIO [=y] && INPUT_MPU3050!=y && INPUT_MPU3050!=m && I2C [=m]
>   - AFE4404 [=m] && IIO [=y] && I2C [=m]
>   - MAX30100 [=m] && IIO [=y] && I2C [=m]
>   - HTS221_I2C [=m] && IIO [=y] && HTS221 [=m]
>   - INV_MPU6050_I2C [=m] && IIO [=y] && I2C_MUX [=m]
>   - IIO_ST_LSM6DSX_I2C [=m] && IIO [=y] && IIO_ST_LSM6DSX [=m]
>   - GP2AP020A00F [=m] && IIO [=y] && I2C [=m]
>   - SENSORS_ISL29028 [=m] && IIO [=y] && I2C [=m]
>   - JSA1212 [=m] && IIO [=y] && I2C [=m]
>   - RPR0521 [=m] && IIO [=y] && I2C [=m]
>   - LTR501 [=m] && IIO [=y] && I2C [=m]
>   - MAX44000 [=m] && IIO [=y] && I2C [=m]
>   - PA12203001 [=m] && IIO [=y] && I2C [=m]
>   - ST_UVIS25_I2C [=m] && IIO [=y] && ST_UVIS25 [=m]
>   - AK8974 [=m] && IIO [=y] && I2C [=m] && OF [=y]
>   - SENSORS_HMC5843_I2C [=m] && IIO [=y] && I2C [=m]
>   - SENSORS_RM3100_I2C [=m] && IIO [=y] && I2C [=m]
>   - LMP91000 [=m] && IIO [=y] && I2C [=m]
>   - BMP280_I2C [=m] && IIO [=y] && BMP280 [=m] && I2C [=m]
>   - HP03 [=m] && IIO [=y] && I2C [=m]
>   - ZPA2326_I2C [=m] && IIO [=y]
>   - MLX90632 [=m] && IIO [=y] && I2C [=m]
> 
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_read':
> regmap-i2c.c:(.text+0x122): undefined reference to `i2c_smbus_read_byte_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_write':
> regmap-i2c.c:(.text+0x157): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_read':
> regmap-i2c.c:(.text+0x182): undefined reference to `i2c_smbus_read_word_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_read_swapped':
> regmap-i2c.c:(.text+0x1b2): undefined reference to `i2c_smbus_read_word_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_write_swapped':
> regmap-i2c.c:(.text+0x1ee): undefined reference to `i2c_smbus_write_word_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_write':
> regmap-i2c.c:(.text+0x217): undefined reference to `i2c_smbus_write_word_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_read':
> regmap-i2c.c:(.text+0x254): undefined reference to `i2c_smbus_read_i2c_block_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_write':
> regmap-i2c.c:(.text+0x2b0): undefined reference to `i2c_smbus_write_i2c_block_data'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_read':
> regmap-i2c.c:(.text+0x312): undefined reference to `i2c_transfer'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_gather_write':
> regmap-i2c.c:(.text+0x39c): undefined reference to `i2c_transfer'
> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_write':
> regmap-i2c.c:(.text+0x3f4): undefined reference to `i2c_transfer_buffer_flags'
> ld: drivers/extcon/extcon-ptn5150.o: in function `ptn5150_i2c_init':
> extcon-ptn5150.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
> 
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: Vijai Kumar K <vijaikumar.kanagarajan@...il.com>
> ---
>  drivers/extcon/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm-2019-0225-1340.orig/drivers/extcon/Kconfig
> +++ mmotm-2019-0225-1340/drivers/extcon/Kconfig
> @@ -116,7 +116,7 @@ config EXTCON_PALMAS
>  
>  config EXTCON_PTN5150
>  	tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
> -	depends on I2C && GPIOLIB || COMPILE_TEST
> +	depends on I2C && GPIOLIB
>  	select REGMAP_I2C
>  	help
>  	  Say Y here to enable support for USB peripheral and USB host
> 
> 
>