linux-kernel - Re: [PATCH 0/3] mincore() and IOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190306152337.e06cbc530fbfbcfcfe0dc37c@linux-foundation.org>
Date:   Wed, 6 Mar 2019 15:23:37 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-api@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jann Horn <jannh@...gle.com>,
        Andy Lutomirski <luto@...capital.net>,
        Cyril Hrubis <chrubis@...e.cz>, Daniel Gruss <daniel@...ss.cc>,
        Dave Chinner <david@...morbit.com>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Kevin Easton <kevin@...rana.org>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Matthew Wilcox <willy@...radead.org>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 0/3] mincore() and IOCB_NOWAIT adjustments

On Wed, 6 Mar 2019 23:48:03 +0100 (CET) Jiri Kosina <jikos@...nel.org> wrote:

> 3/3 is actually waiting for your decision, see
> 
> 	https://lore.kernel.org/lkml/20190212063643.GL15609@dhcp22.suse.cz/

I pity anyone who tried to understand this code by reading this code. 
Can we please get some careful commentary in there explaining what is
going on, and why things are thus?

I guess the [3/3] change makes sense, although it's unclear whether
anyone really needs it?  5.0 was released with 574823bfab8 ("Change
mincore() to count "mapped" pages rather than "cached" pages") so we'll
have a release cycle to somewhat determine how much impact 574823bfab8
has on users.  How about I queue up [3/3] and we reevaluate its
desirability in a couple of months?