lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 6 Mar 2019 05:19:11 +0000
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     saumah <saumah@...il.com>
Cc:     Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Morris Ku <morris_ku@...ix.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3] parport_serial.c change for fix hanging problem.

On Tue, Feb 19, 2019 at 9:23 AM saumah <saumah@...il.com> wrote:
>
> parport_serial.c change for fix hanging problem while suspend machine. parport_seria.c support the same vendor id and device id definition as sunix multi-I/O card driver, when the sunix multi-io borad driver is installed,there are two drivers to support the same sunix multi-io card,it will cause operation error.
>

Please use checkpatch to check your patch.

> Signed-off-by: saumah <saumah@...il.com>

> ---
>  parport_serial.c | 180 +----------------------------------------------
>  1 file changed, 1 insertion(+), 179 deletions(-)
>
> diff --git a/parport_serial.c b/parport_serial.c
> index ae9e01e..f54d1d3 100644
> --- a/parport_serial.c
> +++ b/parport_serial.c

This doesnot apply. git is showing error:
error: parport_serial.c: No such file or directory

> @@ -38,29 +38,10 @@ enum parport_pc_pci_cards {
>         siig_2p1s_20x,
<snip>
>
>  /* each element directly indexed from enum list, above */
> @@ -127,29 +108,10 @@ static struct parport_pc_pci cards[] = {
>         /* siig_2p1s_20x */             { 2, { { 1, 2 }, { 3, 4 }, } },
>         /* siig_1s1p_20x */             { 1, { { 1, 2 }, } },
>         /* siig_2s1p_20x */             { 1, { { 2, 3 }, } },
> -       /* timedia_4078a */             { 1, { { 2, -1 }, } },

You are removing support for the parallel port of these boards. Can
you please point me to the driver with which it conflicts.

-- 
Regards
Sudip

Powered by blists - more mailing lists