linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64c92d9b653786e4e35952c1c37e0718@codeaurora.org>
Date:   Wed, 06 Mar 2019 11:14:33 +0530
From:   Balakrishna Godavarthi <bgodavar@...eaurora.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hemantg <hemantg@...eaurora.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to
 zero

On 2019-03-06 02:34, Matthias Kaehlcke wrote:
> The qca_data structure is allocated with kzalloc() and hence
> zero-initialized. Remove a bunch of unnecessary explicit
> initializations of struct members to zero.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  drivers/bluetooth/hci_qca.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 237aea34b69f1..8dccbb934e384 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -480,26 +480,7 @@ static int qca_open(struct hci_uart *hu)
>  	qca->tx_ibs_state = HCI_IBS_TX_ASLEEP;
>  	qca->rx_ibs_state = HCI_IBS_RX_ASLEEP;
> 
> -	/* clocks actually on, but we start votes off */
> -	qca->tx_vote = false;
> -	qca->rx_vote = false;
> -	qca->flags = 0;
> -
> -	qca->ibs_sent_wacks = 0;
> -	qca->ibs_sent_slps = 0;
> -	qca->ibs_sent_wakes = 0;
> -	qca->ibs_recv_wacks = 0;
> -	qca->ibs_recv_slps = 0;
> -	qca->ibs_recv_wakes = 0;
>  	qca->vote_last_jif = jiffies;
> -	qca->vote_on_ms = 0;
> -	qca->vote_off_ms = 0;
> -	qca->votes_on = 0;
> -	qca->votes_off = 0;
> -	qca->tx_votes_on = 0;
> -	qca->tx_votes_off = 0;
> -	qca->rx_votes_on = 0;
> -	qca->rx_votes_off = 0;
> 
>  	hu->priv = qca;

Reviewed-by: Balakrishna Godavarthi <bgodavar@...eaurora.org>

-- 
Regards
Balakrishna.