linux-kernel - Re: [PATCH] arm64: dts: add gce node for mt8183

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 09:47:39 +0800
From:   houlong wei <houlong.wei@...iatek.com>
To:     CK Hu <ck.hu@...iatek.com>, <bibby.hsieh@...iatek.com>
CC:     Bibby Hsieh (謝濟遠) 
        <Bibby.Hsieh@...iatek.com>, Jassi Brar <jassisinghbrar@...il.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Daniel Kurtz" <djkurtz@...omium.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        srv_heupstream <srv_heupstream@...iatek.com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Nicolas Boichat" <drinkcat@...omium.org>,
        YT Shen (沈岳霆) 
        <Yt.Shen@...iatek.com>,
        Daoyuan Huang (黃道原) 
        <Daoyuan.Huang@...iatek.com>,
        Jiaguang Zhang (张加广) 
        <Jiaguang.Zhang@...iatek.com>,
        Dennis-YC Hsieh (謝宇哲) 
        <Dennis-YC.Hsieh@...iatek.com>,
        Ginny Chen (陳治傑) 
        <ginny.chen@...iatek.com>,
        Kendrick Hsu (徐子凡) 
        <Kendrick.Hsu@...iatek.com>,
        Frederic Chen (陳俊元) 
        <Frederic.Chen@...iatek.com>, <houlong.wei@...iatek.com>
Subject: Re: [PATCH] arm64: dts: add gce node for mt8183

On Thu, 2019-03-07 at 09:24 +0800, CK Hu wrote:
> Hi, Bibby:
> 
> On Wed, 2019-03-06 at 18:10 +0800, Bibby Hsieh wrote: 
> > This patch need based on v5.0-rc1 and these series
> > http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017570.html
> > http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017320.html
> > http://lists.infradead.org/pipermail/linux-mediatek/2019-January/017196.html
> > http://lists.infradead.org/pipermail/linux-mediatek/2019-March/018005.html
> > 
> > add gce device node for mt8183
> > 
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@...iatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 165b859..5006368 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -8,6 +8,7 @@
> >  #include <dt-bindings/clock/mt8183-clk.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/gce/mt8183-gce.h>
> >  #include "mt8183-pinfunc.h"
> >  
> >  / {
> > @@ -238,6 +239,18 @@
> >  			clock-names = "spi", "wrap";
> >  		};
> >  
> > +		gce: gce@...38000 {
> > +			compatible = "mediatek,mt8183-gce";
> > +			reg = <0 0x10238000 0 0x4000>;
> > +			interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
> > +			thread-num = <CMDQ_THR_MAX_COUNT>;
> 
> I does not find 'thread-num' in binding document [1].
> 
> [1]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> 
> Regards,
> CK

The property "thread-num" is not used and and it was removed from the
properties description, but I forgot to remove it from the example. That
is misleading and I'm sorry for that. @Bibby, could you please help
remove it from the example in mtk-gce.txt if you would upload a new
version?
> 
> > +			#mbox-cells = <3>;
> > +			#gce-event-cells = <1>;
> > +			#gce-subsys-cells = <2>;
> > +			clocks = <&infracfg CLK_INFRA_GCE>;
> > +			clock-names = "gce";
> > +		};
> > +
> >  		uart0: serial@...02000 {
> >  			compatible = "mediatek,mt8183-uart",
> >  				     "mediatek,mt6577-uart";
>