linux-kernel - Re: [PATCH] habanalabs: use %px instead of %p in error print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLGCfP8Wv58swP_=w6-xNSOvOqZW9WUjSMaJQAXbYHnSQ@mail.gmail.com>
Date:   Wed, 6 Mar 2019 19:46:04 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] habanalabs: use %px instead of %p in error print

On Sat, Mar 2, 2019 at 1:43 AM Oded Gabbay <oded.gabbay@...il.com> wrote:
>
> When parsing the address of an internal command buffer, the driver prints
> an error if the buffer's address is not in the range of the device's DRAM
> or SRAM memory address space.
>
> Use %px to print the real address that the user gave the driver and not a
> hashed value, so the user will get a clue regarding the origin of his
> error.
>
> Note that if the print occurs, the pointer that is printed is a
> user's virtual address and not some kind of physical address.

Err, which virtual address space is this? If this is mapped into the
kernel's virtual address space, this should not be %px...

-Kees

>
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Oded Gabbay <oded.gabbay@...il.com>
> ---
>  drivers/misc/habanalabs/goya/goya.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index c4f3ec1e9d8b..238dd57c541b 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -4293,7 +4293,7 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
>                         return 0;
>
>                 dev_err(hdev->dev,
> -                       "Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n",
> +                       "Internal CB address %px + 0x%x is not in SRAM nor in DRAM\n",
>                         parser->user_cb, parser->user_cb_size);
>
>                 return -EFAULT;
> --
> 2.18.0
>


-- 
Kees Cook