linux-kernel - RE: [PATCH V7 3/3] firmware: imx: imx-scu: register build-in child devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 12:26:47 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Anson Huang <anson.huang@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        Andy Gross <andy.gross@...aro.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "arnd@...db.de" <arnd@...db.de>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
        "olof@...om.net" <olof@...om.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V7 3/3] firmware: imx: imx-scu: register build-in child
 devices

[...]

> > diff --git a/drivers/firmware/imx/imx-scu.c
> > b/drivers/firmware/imx/imx-scu.c index 2bb1a19..df75ead 100644
> > --- a/drivers/firmware/imx/imx-scu.c
> > +++ b/drivers/firmware/imx/imx-scu.c
...
> > +	/* register SCU child devices which are NOT in device tree */
> > +	child_pdev = platform_device_register_data(dev, "imx-sc-wdt",
> > +				PLATFORM_DEVID_NONE, NULL, 0);
> > +	if (IS_ERR(child_pdev))
> > +		dev_warn(dev, "failed to register scu watchdog device %ld!\n",
> > +			 PTR_ERR(child_pdev));
> > +
> 
> I just realized ... since this is not a devm_ function, we now also need error
> handling (if devm_of_platform_populate() fails) and a remove function.
> Sorry for that - I should have noticed earlier.
> 

It looks strange to me that instantiate the watchdog device in SCU driver which
actually does not use SCU.

For me, it's actually a watchdog provided by ATF firmware, not SCU.
I explained this to Rob in another mail.
Let's see Rob's comments on it.

If Rob agrees, we can move watchdog node out of SCU and also do not
need instantiate it in SCU driver.

Regards
Dong Aisheng

> Guenter
> 
> >   	return devm_of_platform_populate(dev);
> >   }
> >
> >