linux-kernel - Re: [PATCH] davinci_emac: always build in CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 08:16:58 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] davinci_emac: always build in CONFIG_OF code

On Thu, Mar 07, 2019 at 10:31:20AM +0100, Arnd Bergmann wrote:
> clang warns about what seems to be an unintended use of an obscure C
> language feature where a forward declaration of an array remains usable
> when the final definition is never seen:
> 
> drivers/net/ethernet/ti/davinci_emac.c:1694:34: error: tentative array definition assumed to have one element [-Werror]
> static const struct of_device_id davinci_emac_of_match[];
> 
> There is no harm in always enabling the device tree matching code here,
> and it makes the code behave in a more conventional way aside from
> avoiding the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

> ---
>  drivers/net/ethernet/ti/davinci_emac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
> index 840820402cd0..57450b174fc4 100644
> --- a/drivers/net/ethernet/ti/davinci_emac.c
> +++ b/drivers/net/ethernet/ti/davinci_emac.c
> @@ -2029,7 +2029,6 @@ static const struct dev_pm_ops davinci_emac_pm_ops = {
>  	.resume		= davinci_emac_resume,
>  };
>  
> -#if IS_ENABLED(CONFIG_OF)
>  static const struct emac_platform_data am3517_emac_data = {
>  	.version		= EMAC_VERSION_2,
>  	.hw_ram_addr		= 0x01e20000,
> @@ -2046,14 +2045,13 @@ static const struct of_device_id davinci_emac_of_match[] = {
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, davinci_emac_of_match);
> -#endif
>  
>  /* davinci_emac_driver: EMAC platform driver structure */
>  static struct platform_driver davinci_emac_driver = {
>  	.driver = {
>  		.name	 = "davinci_emac",
>  		.pm	 = &davinci_emac_pm_ops,
> -		.of_match_table = of_match_ptr(davinci_emac_of_match),
> +		.of_match_table = davinci_emac_of_match,
>  	},
>  	.probe = davinci_emac_probe,
>  	.remove = davinci_emac_remove,
> -- 
> 2.20.0
>