linux-kernel - Re: [PATCH] ethtool: reduce stack usage with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 16:59:19 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Wenwen Wang <wang6495@....edu>,
        Ilya Lesokhin <ilyal@...lanox.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Edward Cree <ecree@...arflare.com>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethtool: reduce stack usage with clang

On Thu, Mar 7, 2019 at 11:06 AM Michal Kubecek <mkubecek@...e.cz> wrote:
>
> On Thu, Mar 07, 2019 at 10:33:35AM +0100, Arnd Bergmann wrote:

> > @@ -2533,7 +2535,7 @@ static int ethtool_set_fecparam(struct net_device *dev, void __user *useraddr)
> >
> >  /* The main entry point in this file.  Called from net/core/dev_ioctl.c */
> >
> > -int dev_ethtool(struct net *net, struct ifreq *ifr)
> > +int noinline_for_stack dev_ethtool(struct net *net, struct ifreq *ifr)
> >  {
> >       struct net_device *dev = __dev_get_by_name(net, ifr->ifr_name);
> >       void __user *useraddr = ifr->ifr_data;
>
> Is this part really needed? AFAICS dev_ethtool() is only called from
> dev_ioctl() which is in a different compilation unit so that
> dev_ethtool() won't be inlined anyway.

No, you are right. I had accidentally left this in place from an earlier
version. Sending a v2 now.

      Arnd