linux-kernel - Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 08:11:40 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        linux-kernel@...r.kernel.org, Alessandro Rubini <rubini@...dd.com>,
        Arnd Bergmann <arnd@...db.de>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Cory Maccarrone <darkstar6262@...il.com>,
        Davide Ciminaghi <ciminaghi@...dd.com>,
        Dong Aisheng <dong.aisheng@...aro.org>,
        Graeme Gregory <gg@...mlogic.co.uk>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Haojian Zhuang <haojian.zhuang@...vell.com>,
        Jin Park <jinyoungp@...dia.com>,
        Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        Mattias Nilsson <mattias.i.nilsson@...ricsson.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Venu Byravarasu <vbyravarasu@...dia.com>,
        linux-omap@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers

* Pavel Machek <pavel@....cz> [190307 08:35]:
> 
> > > Pavel, I hope this more extended explanation makes sense to you, and
> > > that you simply have not seen me write these same details in the past.
> > 
> > Blimey.  That's a really long winded way of saying:
> > 
> >   "Modular-ness is actually broken in these drivers; [Paul]'s patches
> >    make that point clear for all to see.  If people (authors/distros)
> >    wish them to be modular, they need to fix them properly."
> 
> Has that been checked?
> 
> I mean... when I saw the patch I thought "perhaps it should be doing
> bool->tristate instead"?

Thinking distors and loadable modules,  for PMICs, only regulators need
to be built-in in most cases. That's at least the case for example with
drivers/mfd/motorola-cpcap.c.

I'd say applying these patches makes sense unless we have people
step up and fix their drivers.

Regards,

Tony