linux-kernel - Re: [tip:x86/urgent] x86/mm: Remove unused variable 'cpu'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ec9d97d-f225-e9be-58dc-fed582d8e45d@hisilicon.com>
Date:   Thu, 7 Mar 2019 08:56:29 +0800
From:   Zhangshaokun <zhangshaokun@...ilicon.com>
To:     <hpa@...or.com>, <linux-kernel@...r.kernel.org>, <cai@....pw>,
        <luto@...nel.org>, <tglx@...utronix.de>, <mingo@...nel.org>,
        <linux-tip-commits@...r.kernel.org>, Borislav Petkov <bp@...e.de>
Subject: Re: [tip:x86/urgent] x86/mm: Remove unused variable 'cpu'

A little confused,
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/cleanups&id=691b9ab6c9676e5868a4787be9041dd990005311

On 2019/3/7 6:33, tip-bot for Qian Cai wrote:
> Commit-ID:  3609e31bc8dc03b701390f79c74fc7fe92b95039
> Gitweb:     https://git.kernel.org/tip/3609e31bc8dc03b701390f79c74fc7fe92b95039
> Author:     Qian Cai <cai@....pw>
> AuthorDate: Thu, 28 Feb 2019 17:01:55 -0500
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Wed, 6 Mar 2019 23:24:52 +0100
> 
> x86/mm: Remove unused variable 'cpu'
> 
> The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
> flush_tlb_others() etc") removed the unnecessary cpu parameter from
> uv_flush_tlb_others() but left an unused variable.
> 
> arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
> arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
> [-Wunused-but-set-variable]
>    unsigned int cpu;
>                 ^~~
> 
> Fixes: a2055abe9c67 ("x86/mm: Pass flush_tlb_info to flush_tlb_others() etc")
> Signed-off-by: Qian Cai <cai@....pw>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Acked-by: Andyt Lutomirski <luto@...nel.org>
> Cc: dave.hansen@...ux.intel.com
> Cc: peterz@...radead.org
> Cc: bp@...en8.de
> Cc: hpa@...or.com
> Link: https://lkml.kernel.org/r/20190228220155.88124-1-cai@lca.pw
> 
> ---
>  arch/x86/mm/tlb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 999d6d8f0bef..bc4bc7b2f075 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -685,9 +685,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
>  		 * that UV should be updated so that smp_call_function_many(),
>  		 * etc, are optimal on UV.
>  		 */
> -		unsigned int cpu;
> -
> -		cpu = smp_processor_id();
>  		cpumask = uv_flush_tlb_others(cpumask, info);
>  		if (cpumask)
>  			smp_call_function_many(cpumask, flush_tlb_func_remote,
> 
> .
>