linux-kernel - Re: [PATCH v2 1/2] irqchip: stm32: don't clear rising/falling config registers at init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 18:11:40 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Fabien Dessenne <fabien.dessenne@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Cc:     Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH v2 1/2] irqchip: stm32: don't clear rising/falling config
 registers at init

On 07/03/2019 17:36, Fabien Dessenne wrote:
> falling and rising configuration and status registers are not banked.
> As they are shared with M4 co-processor, they should not be cleared
> at probe time, else M4 co-processor configuration will be lost.
> 
> Signed-off-by: Loic Pallardy <loic.pallardy@...com>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> ---
>  drivers/irqchip/irq-stm32-exti.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index 6edfd4b..dab37fb 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -735,11 +735,6 @@ stm32_exti_chip_data *stm32_exti_chip_init(struct stm32_exti_host_data *h_data,
>  	 */
>  	writel_relaxed(0, base + stm32_bank->imr_ofst);
>  	writel_relaxed(0, base + stm32_bank->emr_ofst);
> -	writel_relaxed(0, base + stm32_bank->rtsr_ofst);
> -	writel_relaxed(0, base + stm32_bank->ftsr_ofst);
> -	writel_relaxed(~0UL, base + stm32_bank->rpr_ofst);
> -	if (stm32_bank->fpr_ofst != UNDEF_REG)
> -		writel_relaxed(~0UL, base + stm32_bank->fpr_ofst);
>  
>  	pr_info("%pOF: bank%d\n", h_data->node, bank_idx);
>  
> 

As for the initial patch, I'm asking for a "Fixes:" tag.

	M.
-- 
Jazz is not dead. It just smells funny...