linux-kernel - Re: [PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec time and boost performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 19:29:16 +0100
From:   Holger Hoffstätte <holger@...lied-asynchrony.com>
To:     Paolo Valente <paolo.valente@...aro.org>,
        Jens Axboe <axboe@...nel.dk>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        ulf.hansson@...aro.org, linus.walleij@...aro.org,
        broonie@...nel.org, bfq-iosched@...glegroups.com,
        oleksandr@...alenko.name, fra.fra.800@...il.com
Subject: Re: [PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec
 time and boost performance

On 3/7/19 5:25 PM, Paolo Valente wrote:
> Hi,
> since I didn't make it to submit these ones for 5.1, let me be
> early for 5.2 :)
> 
> These patches fix some bug affecting performance, reduce execution
> time a little bit, and boost throughput and responsiveness.
> 
> They are meant to be applied on top of the last series I submitted:
> https://lkml.org/lkml/2019/1/29/368

I have the earlier series applied & working well. This one applies cleanly
on top, but something's wrong with the bfq_log_bfqq() macro:

   CC [M]  block/bfq-iosched.o
In file included from block/bfq-iosched.c:140:
block/bfq-iosched.c: In function 'bfq_check_fifo':
block/bfq-iosched.h:1058:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   char pid_str[MAX_PID_STR_LENGTH]; \
   ^~~~
block/bfq-iosched.c:890:2: note: in expansion of macro 'bfq_log_bfqq'
   bfq_log_bfqq(bfqq->bfqd, bfqq, "check_fifo: returned %p", rq);
   ^~~~~~~~~~~~
block/bfq-iosched.c: In function 'bfq_updated_next_req':
block/bfq-iosched.h:1058:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

This is with gcc 8.3.0 on top of 5.0++.

thanks,
Holger