linux-kernel - Re: [PATCH] mmc: pxamci: fix enum type confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mum65wdg.fsf@belgarion.home>
Date:   Thu, 07 Mar 2019 20:15:39 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Daniel Mack <daniel@...que.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: pxamci: fix enum type confusion

Nathan Chancellor <natechancellor@...il.com> writes:

> On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote:
>> clang points out several instances of mismatched types in this drivers,
>> all coming from a single declaration:
>> 
>> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
>>       different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
>>                 direction = DMA_DEV_TO_MEM;
>>                           ~ ^~~~~~~~~~~~~~
>> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
>>       different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
>>         tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
>> 
>> The behavior is correct, so this must be a simply typo from
>> dma_data_direction and dma_transfer_direction being similarly named
>> types with a similar purpose.
>> 
>> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Reviewed-by: Nathan Chancellor <natechancellor@...il.com>
Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Cheers.

--
Robert